v2ray-geodata: provide a virtual package #28235
Conversation
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Fixes: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
teleostnacl
force-pushed
the
fix-v2ray-geodata-provide
branch
from
532175d to
0b2e822
Compare
|
Hello @GeorgeSapkin, could you please help review this? |
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Fixes: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
teleostnacl
force-pushed
the
fix-v2ray-geodata-provide
branch
from
0b2e822 to
21bd45c
Compare
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Related: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
teleostnacl
force-pushed
the
fix-v2ray-geodata-provide
branch
from
21bd45c to
964ca66
Compare
|
Hello @GeorgeSapkin I have omitted unnecessary empty lines. And I want to relate this PR in the commit for future reference, so maybe using “Related” would be more appropriate. |
|
I don't think there's any meaningful additional context in this PR compared to the commit description. |
|
Also you should use a GitHub username when specifying maintainers in a PR, and not a name and an email. |
|
I have edited the Maintainer and Description, please check it again, thanks a lot! |
|
And since this is modifying packaging information, you should bump the |
Switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side. Related: openwrt/openwrt#21288 Related: openwrt#28235 Signed-off-by: TeleostNaCl Dai <teleostnacl@gmail.com>
teleostnacl
force-pushed
the
fix-v2ray-geodata-provide
branch
from
964ca66 to
be0456c
Compare
I’m sorry I forgot this important detail. And now I have bumped the |
There was a problem hiding this comment.
So the way virtual provides (i.e. the ones that don't have a version and are marked with a @ sign in the new semantic) work with apk is:
- they don't own the name and can be installed side-by-side
- they can be depended on by something else
- if there is a priority specified, or in case of current implementation - the default variant, that package with the highest possible priority will be selected when installation is requested by name
- if there's no priority specified a variant must be manually chosen
As is, nothing depends on these providers and there's no priority specified, so these provides are kind of informational and I'm not sure I see the point in them. You can't say install v2ray-geodata. If the behavior is supposed to be different, then this needs to be adjusted.
|
This is just a placeholder currently. |
|
I don't mind either way. Just explaining the behavior, so there are no misunderstandings in case something breaks. |
3 participants
📦 Package Details
Maintainer:
@1715173329 Tianling Shen cnsztl@immortalwrt.org
Description:
According to openwrt/openwrt#21288, switch v2ray-geodata provides to use the new virtual provides semantic that enables v2ray-geoip and v2ray-geosite to be installed side-by-side.
This resolves the conflict between the v2ray-geoip and v2ray-geosite packages during
make package/install.Without this PR, the following error occurs when running
make package/install:🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.